Skip to content

feat: Support objectOverrides #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 5 commits into from
Dec 23, 2025
Merged

feat: Support objectOverrides #726

sbernauer merged 5 commits into from
Dec 23, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 23, 2025

Description

Part of stackabletech/issues#712

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer mentioned this pull request Dec 23, 2025
Merged
@sbernauer sbernauer self-assigned this Dec 23, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Dec 23, 2025
@sbernauer sbernauer requested a review from Maleware December 23, 2025 13:23
Maleware
Maleware approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! :)

@sbernauer sbernauer mentioned this pull request Dec 23, 2025
Open
21 tasks
@sbernauer sbernauer added this pull request to the merge queue Dec 23, 2025
Merged via the queue into main with commit ef902e6 Dec 23, 2025
12 checks passed
@sbernauer sbernauer deleted the feat/object-overrides branch December 23, 2025 14:27
@sbernauer sbernauer mentioned this pull request Dec 23, 2025
Closed
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Dec 29, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jan 8, 2026
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jan 8, 2026
NickLarsenNZ
NickLarsenNZ reviewed Jan 9, 2026
View reviewed changes
.pre-commit-config.yaml
- repo: https://github.com/EmbarkStudios/cargo-deny
# Failing to compile cargo-deny with version >0.18.3, needs rust 1.88.0
rev: baa02b0a0c54e0578aae6bb7c7181ad00dc290af # 0.18.3
rev: 8d76e7e991107da82c4a59cdc362a2739539f55d # 0.18.9
Copy link
Member

@NickLarsenNZ NickLarsenNZ Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change need to go into operator-templating: https://github.com/stackabletech/operator-templating/blob/2bd59f09974e5bde1cca110105dfa2fb910e8bf3/template/.pre-commit-config.yaml.j2#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@Maleware Maleware Maleware approved these changes

Assignees

@sbernauer sbernauer

Labels

release/26.3.0

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbernauer @NickLarsenNZ @Maleware @lfrancke